Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perllocale: Update for 5.40 state of affairs #22200

Merged
merged 1 commit into from
May 15, 2024

Conversation

khwilliamson
Copy link
Contributor

This makes corrections, and additions

pod/perllocale.pod Outdated Show resolved Hide resolved
pod/perllocale.pod Outdated Show resolved Hide resolved
@jkeenan
Copy link
Contributor

jkeenan commented May 9, 2024

P.R. is failing t/porting/podcheck.t and short-circuiting CI tests. This patch should fix it.

diff --git a/pod/perllocale.pod b/pod/perllocale.pod
index e07e6e2696..31f17373f9 100644
--- a/pod/perllocale.pod
+++ b/pod/perllocale.pod
@@ -102,7 +102,7 @@ Perl runs.  This category is a POSIX extension, and Windows, for
 example, doesn't have it.  On systems without it, Perl uses workarounds
 to compensate.
 
-=head2 Category C<LC_ALL>
+=item Category C<LC_ALL>
 
 This is not an actual category, but a convenience short-hand to refer to
 all of the actual ones.

@leonerd
Copy link
Contributor

leonerd commented May 9, 2024

Overall looks good. If you can address Jim's comments + the failing test we can pop this in for 5.40.

@khwilliamson
Copy link
Contributor Author

This removes some text applicable to XS code only; I will soon add text to perlxs.pod to address that

pod/perllocale.pod Outdated Show resolved Hide resolved
pod/perllocale.pod Outdated Show resolved Hide resolved
This makes corrections, and additions
@khwilliamson khwilliamson merged commit bcedd58 into Perl:blead May 15, 2024
29 checks passed
@khwilliamson khwilliamson deleted the perllocale branch May 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants