Fcntl: remove pointless S_ISENFMT function #22202
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S_ISENFMT($mode) has no equivalent C macro. It was implemented (in XS) as the equivalent of
($mode & S_IFMT) == S_ENFMT
, which is always false because S_ENFMT is not a file type and thus not covered by the S_IFMT mask.(See commits ca6e1c2, 0e6f150, 0f68039, fb59364, 87eca6e for the history of this function, which has always been broken in various ways ever since it was added in 2000.)
Fixes #22190.