Bump typescript from 4.9.5 to 5.0.2 #263
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.0.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/typescript-5.0.2
branch
from
f37c586
to
db9dd7d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 95.30% 95.65% +0.35%
==========================================
Files 48 48
Lines 830 828 -2
Branches 151 150 -1
==========================================
+ Hits 791 792 +1
+ Misses 38 35 -3
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Seriously, though, our tests passed, so it is probably safe. But the major version change suggests potentially breaking changes. Do we want to upgrade, @slifty, @reefdog, @gmurtaza00, @jasonaowen ? |
There was a problem hiding this comment.
I looked through the release notes, and especially the breaking changes section, and did not see anything concerning. CI does include a build step, so I think we have a reasonable level of confidence that there are no breaking changes here.
Note the codecov/patch check seems to be a failure relating to #124; I noticed then that codecov hadn't run on the latest force push to that PR's branch, but I don't know why. I'm fine to merge despite that.
|
Oh, note that running the tests now produces a warning:
There is an upstream issue open: kulshekhar/ts-jest#4048 I don't think this is enough to revert over, as the tests still pass, but I am happy to be overridden by @bickelj or @slifty. |
|
If our tests pass (they did) I am happy to upgrade. I think we just keep it in mind if there are weird test issues in the future and try 4.x locally to see if that was it. But hopefully by that time |
Bumps typescript from 4.9.5 to 5.0.2.
Release notes
Sourced from typescript's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)