IdentityConversion: drop *Sorted* candidates

PicnicSupermarket · Feb 11, 2022 · b45636f · b45636f
1 parent d0f6af6
commit b45636f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/...one-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/IdentityConversionCheck.java b/...one-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/IdentityConversionCheck.java
@@ -47,9 +47,6 @@ public final class IdentityConversionCheck extends BugChecker
                   "com.google.common.collect.ImmutableRangeSet",
                   "com.google.common.collect.ImmutableSet",
                   "com.google.common.collect.ImmutableSetMultimap",
-                  "com.google.common.collect.ImmutableSortedMap",
-                  "com.google.common.collect.ImmutableSortedMultiset",
-                  "com.google.common.collect.ImmutableSortedSet",
                   "com.google.common.collect.ImmutableTable")
               .named("copyOf"),
           staticMethod()

diff --git a/...contrib/src/test/java/tech/picnic/errorprone/bugpatterns/IdentityConversionCheckTest.java b/...contrib/src/test/java/tech/picnic/errorprone/bugpatterns/IdentityConversionCheckTest.java
@@ -27,9 +27,6 @@ void identification() {
             "import com.google.common.collect.ImmutableRangeSet;",
             "import com.google.common.collect.ImmutableSet;",
             "import com.google.common.collect.ImmutableSetMultimap;",
-            "import com.google.common.collect.ImmutableSortedMap;",
-            "import com.google.common.collect.ImmutableSortedMultiset;",
-            "import com.google.common.collect.ImmutableSortedSet;",
             "import com.google.common.collect.ImmutableTable;",
             "import reactor.adapter.rxjava.RxJava2Adapter;",
             "import reactor.core.publisher.Flux;",
@@ -83,13 +80,7 @@ void identification() {
             "    // BUG: Diagnostic contains:",
             "    ImmutableSetMultimap<Object, Object> i11 = ImmutableSetMultimap.copyOf(ImmutableSetMultimap.of());",
             "    // BUG: Diagnostic contains:",
-            "    ImmutableSortedMap<Object, Object> i12 = ImmutableSortedMap.copyOf(ImmutableSortedMap.of());",
-            "    // BUG: Diagnostic contains:",
-            "    ImmutableSortedMultiset<Object> i13 = ImmutableSortedMultiset.copyOf(ImmutableSortedMultiset.of());",
-            "    // BUG: Diagnostic contains:",
-            "    ImmutableSortedSet<Object> i14 = ImmutableSortedSet.copyOf(ImmutableSortedSet.of());",
-            "    // BUG: Diagnostic contains:",
-            "    ImmutableTable<Object, Object, Object> i15 = ImmutableTable.copyOf(ImmutableTable.of());",
+            "    ImmutableTable<Object, Object, Object> i12 = ImmutableTable.copyOf(ImmutableTable.of());",
             "",
             "    // BUG: Diagnostic contains:",
             "    Flux<Integer> f1 = Flux.just(1).flatMap(e -> RxJava2Adapter.fluxToFlowable(Flux.just(2)));",