Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the .gitignore and add .idea/jarRepositories.xml #1

Closed
wants to merge 1 commit into from

Conversation

rickie
Copy link
Member

@rickie rickie commented Aug 28, 2021

No description provided.

@rickie rickie requested a review from Stephan202 August 28, 2021 07:09
@rickie rickie changed the title Add .idea/jarRepositories.xml to the .gitignore Add .idea/jarRepositories.xml to the .gitignore Sep 9, 2021
@rickie rickie force-pushed the rossendrijver/change_gitignore branch from f35d650 to c49fca9 Compare September 20, 2021 05:35
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this proposal :)

(Maybe we should also suggest sorting the file's entries? 🤔.)

@rickie
Copy link
Member Author

rickie commented Oct 10, 2021

Yeah I agree, I pushed something.

@rickie rickie changed the title Add .idea/jarRepositories.xml to the .gitignore Sort the .gitignore and add .idea/jarRepositories.xml Oct 10, 2021
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggested PR/commit message:

Sort `.gitignore` and add `.idea/jarRepositories.xml` to it

@rickie rickie force-pushed the rossendrijver/change_gitignore branch from 9b55ae4 to fb70a2c Compare October 11, 2021 13:02
@rickie rickie force-pushed the rossendrijver/change_gitignore branch from fb70a2c to c9a786e Compare October 11, 2021 13:03
@rickie
Copy link
Member Author

rickie commented Oct 11, 2021

Opened PR upstream google#2616

@rickie rickie closed this Oct 11, 2021
@Stephan202 Stephan202 deleted the rossendrijver/change_gitignore branch June 8, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants