Ignore disabled checks passed to -XepPatchChecks
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
requested changes
Jul 24, 2023
check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java
Outdated
Show resolved
Hide resolved
check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java
Outdated
Show resolved
Hide resolved
check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java
Outdated
Show resolved
Hide resolved
check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java
Outdated
Show resolved
Hide resolved
oxkitsune
force-pushed
the
gdejong/remove-disabled-checks
branch
from
163e405
to
9af0e66
Compare
oxkitsune
commented
Jul 26, 2023
check_api/src/main/java/com/google/errorprone/BaseErrorProneJavaCompiler.java
Outdated
Show resolved
Hide resolved
rickie
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Added a small commit. Really nice fix @oxkitsune 🚀 !
Suggested commit message:
Don't consider disabled checks passed to `-XepPatchChecks`
Fixes #3908.
Alternative suggested commit message:
Have `ScannerSupplier#applyOverrides` only consider enabled checks
Fixes #3908.
Consider could also be a different word like "modify" or "update".
Not too happy with the suggestions, ideas welcome.
| @@ -39,6 +39,23 @@ public class ScannerTest { | |||
| private final CompilationTestHelper compilationHelper = | |||
| CompilationTestHelper.newInstance(ShouldNotUseFoo.class, getClass()); | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
We can move this to the bottom of the class as we are adding it only now. Not a really good reason but it feels like the right thing to do?
There was a problem hiding this comment.
I wasn't exactly sure if this is the right file for the test, but I agree!
Stephan202
force-pushed
the
gdejong/remove-disabled-checks
branch
from
2dc88b7
to
61cc147
Compare
Stephan202
approved these changes
Jul 30, 2023
check_api/src/main/java/com/google/errorprone/BaseErrorProneJavaCompiler.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/google/errorprone/scanner/ScannerTest.java
Outdated
Show resolved
Hide resolved
oxkitsune
force-pushed
the
gdejong/remove-disabled-checks
branch
from
61cc147
to
4d502e0
Compare
|
Upstream PR: google#4028 |
oxkitsune
changed the title
-XepPatchChecks-XepPatchChecks
Rather than throwing an `NoSuchElementException`. Fixes google#3908.
Stephan202
force-pushed
the
gdejong/remove-disabled-checks
branch
from
4d502e0
to
5865373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than throwing an
NoSuchElementException.Related issue: google#3908