Skip to content

Commit

Permalink
requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
varCepheid committed Feb 17, 2024
1 parent 5e2bbc4 commit ee45d65
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/colors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const lightGrey = '#E8E8E8'
export const faintGrey = '#f5f5f5'
export const blue = '#295dc0'
export const red = '#c30000'
export const greenOnPurple = '#47D232'
export const redOnPurple = '#FF3C2E'
export const greenOnPurple = '#4FAC40'
export const redOnPurple = '#D61E42'
export const offBlack = '#333'
export const focusRing = '#0044ff40'
8 changes: 4 additions & 4 deletions src/components/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { RenderableProps, ComponentChildren } from 'preact'
import { ErrorBoundary } from './error-boundary'
import { css } from '@linaria/core'
import { createShadow } from '@/utils/create-shadow'
import { greenOnPurple, pigmicePurple } from '@/colors'
import { pigmicePurple } from '@/colors'
import IconButton, { iconButtonClass } from './icon-button'
import { mdiArrowLeft, mdiMenu } from '@mdi/js'
import clsx from 'clsx'
Expand Down Expand Up @@ -51,7 +51,7 @@ const headerText = css`
color: white;
&:hover {
text-decoration-color: ${greenOnPurple};
text-decoration-color: #47d232;
}
}
`
Expand All @@ -66,7 +66,7 @@ type Props = Merge<
}
>

const Header = ({ name, showBackButton }: Omit<Props, 'class'>) => {
const Header = ({ name, showBackButton = true }: Omit<Props, 'class'>) => {
const [isMenuOpen, setIsMenuOpen] = useState(false)

const toggleMenu = () => setIsMenuOpen((isOpen) => !isOpen)
Expand All @@ -75,7 +75,7 @@ const Header = ({ name, showBackButton }: Omit<Props, 'class'>) => {
return (
<>
<header class={headerStyle}>
{(showBackButton || showBackButton === undefined) && (
{showBackButton && (
<IconButton
icon={mdiArrowLeft}
aria-label="Back"
Expand Down
2 changes: 1 addition & 1 deletion src/routes/event-analysis.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const EventAnalysis: FunctionComponent<Props> = ({ eventKey }) => {
name={
<>
{'Analysis - '}
<a href={`/events/${eventKey}`}> {eventName} </a>
<a href={`/events/${eventKey}`}>{eventName}</a>
</>
}
class={tablePageStyle}
Expand Down
4 changes: 2 additions & 2 deletions src/routes/event-match.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ const EventMatch = ({ eventKey, matchKey }: Props) => {
<Page
name={
<>
{m.group + (m.num ? ' Match ' + m.num : '') + ' - '}
<a href={`/events/${eventKey}`}> {event ? event.name : eventKey} </a>
{`${m.group}${m.num ? ` Match ${m.num}` : ''} - `}
<a href={`/events/${eventKey}`}>{event?.name || eventKey}</a>
</>
}
class={clsx(
Expand Down
2 changes: 1 addition & 1 deletion src/routes/event-team-comments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const EventTeamComments = ({ eventKey, teamNum }: Props) => {
name={
<>
{`Comments: ${teamNum} @ `}
<a href={`/events/${eventKey}`}> {eventName} </a>
<a href={`/events/${eventKey}`}>{eventName}</a>
</>
}
class={commentsPageStyle}
Expand Down
2 changes: 1 addition & 1 deletion src/routes/event-team-matches.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const EventTeamMatches = ({ eventKey, teamNum }: Props) => {
name={
<>
{`Matches: ${teamNum} @ `}
<a href={`/events/${eventKey}`}> {eventName} </a>
<a href={`/events/${eventKey}`}>{eventName}</a>
</>
}
class={eventTeamMatchesStyle}
Expand Down
2 changes: 1 addition & 1 deletion src/routes/event-team.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const EventTeam = ({ eventKey, teamNum }: Props) => {
<span class={pageHeadingStyle}>
<span class={teamHeadingSpanStyle}>
{`${teamNum} @ `}
<a href={`/events/${eventKey}`}> {eventName} </a>
<a href={`/events/${eventKey}`}>{eventName}</a>
</span>
<IconButton
icon={isTeamSaved ? mdiStar : mdiStarOutline}
Expand Down

0 comments on commit ee45d65

Please sign in to comment.