Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement manually-dispatched workflow #11

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

toobuntu
Copy link
Contributor

Okay, seems reasonable. Here's only the manual workflow part.

FYI, uploading artifacts on a macOS runner can sometimes hang. Eventually, the job gets canceled. A re-run should hopefully resolve the issue.

I tested a modified version of the build workflow and it worked and created a release. I have not tested the update-tap workflow.

@PikachuEXE
Copy link
Owner

Time to test

@PikachuEXE PikachuEXE merged commit 69e0dcd into PikachuEXE:master Mar 24, 2024
4 checks passed
@PikachuEXE
Copy link
Owner

First release created
https://github.com/PikachuEXE/homebrew-FreeTube/releases

But is Update Homebrew Tap workflow supposed to be run automatically?

@toobuntu
Copy link
Contributor Author

toobuntu commented Mar 24, 2024

It can also be run manually (workflow_dispatch trigger). Maybe that workflow file needed to be merged first before it would run automatically. I suppose you could delete the release and re-run the build workflow to test that.

Have you manually checked if the sha256 of the release asset matches what’s in the cask definition? That and the version number are the only things that should potentially need updating at this point. It if does match, you could try installing it with Homebrew and see if it runs.

@toobuntu toobuntu deleted the actions/build-manual branch March 24, 2024 09:43
@PikachuEXE
Copy link
Owner

[Build and Release (Manual Trigger)](https://github.com/PikachuEXE/homebrew-FreeTube/actions/workflows/release-manual-trigger.yml) is run after this PR merged

https://github.com/PikachuEXE/homebrew-FreeTube/actions/workflows/update-tap.yml
The workflow should run (whether it creates PR is something else) since release > types > published is specified
The release created is not a draft so I am not sure if the event workflow is listening to is wrong (use created?) or something else is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants