Resolve TS errors: TreeMapper #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prachigarg19
changed the title
|
@prachigarg19 Please resolve conflicts. Is this otherwise complete, or is anything left? |
1. add type for api call 2. resolve `index.tsx` 3. update import in `my-species.tsx`
It's complete |
mohitb35
requested changes
Sep 22, 2023
src/features/user/TreeMapper/Analytics/components/TreePlanted/index.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/ReviewSubmit.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/PlantingLocation.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/PlantingLocation.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/PlantingLocation.tsx
Outdated
Show resolved
Hide resolved
1. Rename SpeciesType and move it to plantLocations.d.ts 2. Rename newSpecies interface
1. Resolve csv error 2. Add comment for csv validation
1. add condition for null plantLocation 2. Update props to remove null in plantLocations 3. Remove treemapper error
src/features/user/TreeMapper/Import/index.tsx - specify type for api handler using <T> format src/features/user/TreeMapper/Import/components/SampleTreeCard.tsx - remove usage of Treemapper namespace - resolve warnings in rhf components
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves typescript errors