fix: Remove all eval for HMR (#814)

Remove all eval for hmr
PlasmoHQ · Nov 10, 2023 · 9ef619e · 9ef619e
1 parent 74aa2da
commit 9ef619e
Show file tree

Hide file tree

Showing 6 changed files with 247 additions and 255 deletions.
diff --git a/cli/create-plasmo/package.json b/cli/create-plasmo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "create-plasmo",
-  "version": "0.83.1",
+  "version": "0.84.0",
   "description": "Create Plasmo Framework Browser Extension",
   "main": "dist/index.js",
   "bin": "bin/index.mjs",

diff --git a/cli/plasmo/package.json b/cli/plasmo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plasmo",
-  "version": "0.83.1",
+  "version": "0.84.0",
   "description": "The Plasmo Framework CLI",
   "publishConfig": {
     "types": "dist/type.d.ts"

diff --git a/core/parcel-config/package.json b/core/parcel-config/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@plasmohq/parcel-config",
-  "version": "0.39.5",
+  "version": "0.40.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -14,7 +14,7 @@
     "@parcel/optimizer-data-url": "2.9.3",
     "@parcel/reporter-bundle-buddy": "2.9.3",
     "@parcel/resolver-default": "2.9.3",
-    "@parcel/runtime-js": "2.9.3",
+    "@parcel/runtime-js": "2.8.3",
     "@parcel/runtime-service-worker": "2.9.3",
     "@parcel/source-map": "2.1.1",
     "@parcel/transformer-babel": "2.9.3",

diff --git a/core/parcel-runtime/package.json b/core/parcel-runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@plasmohq/parcel-runtime",
-  "version": "0.22.1",
+  "version": "0.23.0",
   "description": "Plasmo Parcel Runtime",
   "files": [
     "dist"

diff --git a/core/parcel-runtime/src/utils/hmr-utils.ts b/core/parcel-runtime/src/utils/hmr-utils.ts
@@ -25,13 +25,6 @@ export function hmrDownload(asset: HmrAsset) {
   }
 }
 
-let supportsSourceURL = false
-try {
-  ;(0, eval)('throw new Error("test"); //# sourceURL=test.js')
-} catch (err) {
-  supportsSourceURL = err.stack.includes("test.js")
-}
-
 export async function hmrApplyUpdates(assets: Array<HmrAsset>) {
   global.parcelHotUpdate = Object.create(null)
 
@@ -49,9 +42,7 @@ export async function hmrApplyUpdates(assets: Array<HmrAsset>) {
     )
   })
 
-  const scriptsToRemove = await Promise.all(
-    supportsSourceURL ? [] : assets.map(hmrDownload)
-  )
+  const scriptsToRemove = await Promise.all(assets.map(hmrDownload))
 
   try {
     assets.forEach(function (asset) {
@@ -146,12 +137,6 @@ function hmrApply(bundle: ParcelBundle, asset: HmrAsset) {
         }
       }
 
-      if (supportsSourceURL) {
-        // Global eval. We would use `new Function` here but browser
-        // support for source maps is better with eval.
-        ;(0, eval)(asset.output)
-      }
-
       const fn = global.parcelHotUpdate[asset.id]
       modules[asset.id] = [fn, deps]
     } else if (bundle.parent) {