Ignore certain files when deciding what needs an update. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also only allow publishing from master.
justinfagnani
approved these changes
Apr 10, 2018
lerna.json
Outdated
| "CHANGELOG.md", | ||
| ".travis.yml", | ||
| "appveyor.yml", | ||
| ".gitignore", |
There was a problem hiding this comment.
we really should just remove all the .gitignores
rictic
approved these changes
Apr 10, 2018
|
I removed the changelog and test file glob from this list. The idea is that if a dependent has picked up an important bug fix, that should be reflected in the CHANGELOG, and maybe also in their tests, and we would want to trigger a release. I should also point out that this lerna feature doesn't actually appear to work in my experience so far, and other users seem to be reporting the same thing: lerna/lerna#1357 |
aomarks
added a commit
that referenced
this pull request
Jul 9, 2018
Bump analyzer; bump test fixture; prepare 1.2.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also only allow publishing from master.
Reference: https://github.com/lerna/lerna#lernajson and https://github.com/lerna/lerna#--allow-branch-glob
(not convinced this is working yet)