Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix tests after merging ES module based app shell. #142

Closed
shaper opened this issue Jan 16, 2018 · 3 comments
Closed

Fix tests after merging ES module based app shell. #142

shaper opened this issue Jan 16, 2018 · 3 comments
Assignees

Comments

@shaper
Copy link
Contributor

shaper commented Jan 16, 2018

Preparing to land the es6-modulify branch. Known items to resolve subsequently:

  • gift shopping demo flow selenium test is broken (actual test seems to duplicate the final clause in the description text incorrectly, perhaps a template issue)
  • arc-app.html not yet converted, thus app-shell.html still remains as well. Possible cdn path construction issue to resolve.
  • unit tests for persistent-arc.html, dancing-dots.html, and good-map.html are disabled as they need to import the involved code which now lives in ES modules. Fixing may require emulating what arcs does via sigh test to generate and run mocha tests in a manner as touched upon in Support ES6 style tests without transpiler usage mochajs/mocha#3006

FYI @sjmiles

@sjmiles
Copy link
Contributor

sjmiles commented Jan 16, 2018

  • localize dependencies instead of list in AppShell.js
  • remove window globals for ArcsUtils and Xen*

@shaper
Copy link
Contributor Author

shaper commented Jan 22, 2018

Only one item remains: "...unit tests for persistent-arc.html, dancing-dots.html, and good-map.html..."

@smalls
Copy link
Member

smalls commented Feb 14, 2018

Now tracked by PolymerLabs/arcs#713.

@smalls smalls closed this as completed Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants