Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests for persistent-arc.html, dancing-dots.html, and good-map.html #713

Closed
smalls opened this issue Feb 14, 2018 · 2 comments
Closed

unit tests for persistent-arc.html, dancing-dots.html, and good-map.html #713

smalls opened this issue Feb 14, 2018 · 2 comments
Assignees
@shaper

Comments

@smalls
Copy link
Member

smalls commented Feb 14, 2018

More information in the original PolymerLabs/arcs-cdn#142.
@smalls smalls added the shell Problem specific to (one of) the shells. label Feb 14, 2018
@smalls smalls mentioned this issue Feb 14, 2018
Closed
@smalls
Copy link
Member Author

smalls commented Feb 20, 2018

More context from the original issue:

unit tests for persistent-arc.html, dancing-dots.html, and good-map.html are disabled as they need to import the involved code which now lives in ES modules. Fixing may require emulating what arcs does via sigh test to generate and run mocha tests in a manner as touched upon in mochajs/mocha#3006

This appears to be what remains. See also TODOs in shell/test/index.test.html.

CC @shaper (original filer of PolymerLabs/arcs-cdn#142).

smalls added a commit to smalls/arcs that referenced this issue Feb 27, 2018
@smalls
disable the extension test until the test can support code in ES6 mod…
da79cef 
…ules

See PolymerLabs/arcs#713 for the blocking issue.
smalls added a commit to smalls/arcs that referenced this issue Mar 2, 2018
@smalls
disable the extension test until the test can support code in ES6 mod…
cf17592 
…ules

See PolymerLabs/arcs#713 for the blocking issue.
smalls added a commit to smalls/arcs that referenced this issue Mar 2, 2018
@smalls
disable the extension test until the test can support code in ES6 mod…
6ca760d 
…ules

See PolymerLabs/arcs#713 for the blocking issue.
smalls added a commit that referenced this issue Mar 5, 2018
@smalls
disable the extension test until the test can support code in ES6 mod…
d38949a 
…ules

See #713 for the blocking issue.
@shaper
Copy link
Contributor

shaper commented Nov 28, 2018

Stale.

@shaper shaper closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaper shaper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaper @smalls