Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a JumpPad asset #144

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

saketepe
Copy link
Contributor

Rn it is just a picture but it should give a bounce effect to the player(Any other files are not to be added unless needed)

@lejara
Copy link
Collaborator

lejara commented Nov 16, 2018

I am having trouble understanding the reason for this pr?
I don't think we need a jump pad asset.

Also, there are some unnecessary changes in your pr. It seems like you opened and committed the game in a newer version of unity.

@saketepe
Copy link
Contributor Author

saketepe commented Nov 18, 2018 via email

@PopeSpaceous
Copy link
Owner

@saketepe Is this just a png file that has been added or have you wrote a script to go with the jump pad?

I do like the Idea of a platform level so it wouldn't be terrible to have a functioning asset.

We would have to edit the image to make it more inline with our current style.

@saketepe
Copy link
Contributor Author

saketepe commented Dec 8, 2018 via email

@PopeSpaceous
Copy link
Owner

@saketepe no rush. Likely won't be merged until after the semester is over. Afterwards I could help you with the styling as I did most of the sprites for the project. Also join the discord channel if you get the chance. @Dragomegak is also learning the scripts for creating assets.
Good luck with finals.

Copy link
Owner

@PopeSpaceous PopeSpaceous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to get this merged we need to setup the Jump Pad into the same style as the rest of the assets.
We also need to create a script for implementing the jump pad into an in game asset.

We also have to clean up the additional files added from using a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants