-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed value: Crytogram to value: Cryptogram #151
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DavidLi119
Thanks for the change.
I was wondering if you had tested the files (the in game cryptogram puzzle) and checked if they worked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David,
I tested the update and it causes the game to crash when you try to open the Cryptogram puzzles.
I recieved this error:
"Scene 'Cryptogram' couldn't be loaded because it has not been added to the build settings or the AssetBundle has not been loaded."
I think what is causing this is that the name change has broken the link to invoke the puzzle.
What you can do to find what needs to be changed is search the content of all the files with "crytogram" still there and that should point you to the files you need to change.
Try running this grep command in your local folder. |
Thanks, I'll get to it soon. |
So I've made a commit of all files and the folder named Crytogram renamed to Cryptogram and all references I could find. I do not use a linux computer and for some reason grep does not work, command prompt or VSCode terminal. Please test |
I'll give it a test when I can. |
So i just used the file explorer and made a few more changes from cryt to crypt |
I'm still receiving an error in the game when I try to open a cryptogram puzzle. There are still some things that need changing. Here is a result from my grep search.
|
I made those changes already, looks like i forgot to push to origin. Just did it, sorry about that |
Changed for issue #108