New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more config examples to CLI #3481
base: main
Are you sure you want to change the base?
Conversation
src/PostgREST/CLI.hs
Outdated
| | ||
|## The standard connection URI format, documented at | ||
|## https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING | ||
|ALTER ROLE authenticator SET pgrst.db_uri = 'postgresql://'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a setting that is possible to set via database configuration. I suggest you go check the code which of those settings are actually possible to set via database config - because there's more than just this that don't make sense here at all.
- #3248, Add more config examples to CLI - @taimoorzaeem | ||
+ Now accepts ``--example-file``, ``--example-db``, and ``--example-env`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also have two changes here, one to rename the dump schema cache command and the other to remove --example
and -e
. Those should probably go into the changed section as well.
2263bc0
to
e503947
Compare
src/PostgREST/CLI.hs
Outdated
[str|-- Enables the aggregate functions in postgresql | ||
|-- ALTER ROLE authenticator SET pgrst.db_aggregates_enabled = 'false'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you added this - but only in the db settings. I guess we have quite a few settings which are not in those example config files by now, because that's always forgotten when adding a new config.
It would probably be good to go through all of them and add them to all three (two for those with are not db-configurable) examples.
src/PostgREST/CLI.hs
Outdated
| | ||
|-- Unix socket location | ||
|-- if specified it takes precedence over server-port | ||
|-- ALTER ROLE authenticator SET pgrst.server_unix_socket = '/tmp/pgrst.sock'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | |
|-- Unix socket location | |
|-- if specified it takes precedence over server-port | |
|-- ALTER ROLE authenticator SET pgrst.server_unix_socket = '/tmp/pgrst.sock'; |
This is not in the list of dbSettingsNames
.
@wolfgangwalther Hmm, I have noticed an inconsistency between |
A good catch. I added it in aef29d4.
We removed raw-media-types in v12.0.0 and replaced it with aggregation / media handlers. Removed the left-over in c6f152f. |
Please rebase, solving conflicts with CHANGELOG.md. |
e503947
to
cce425e
Compare
Closes #3248.