Add support for dnsdist 1.9 #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 21, 2023 13:30
|
(The ansible-lint error involves a spacing issue in, I shit you not, the .ansible-lint file. I haven't touched it) |
|
Went in and cleared it up. Apparently YAML wants two spaces before an inline comment now. |
npmdnl
reviewed
Jan 8, 2024
npmdnl
reviewed
Jan 8, 2024
npmdnl
requested changes
Jan 8, 2024
|
Thanks for the suggestions, they look good. I'm headed out-of-country tomorrow evening; anything I haven't fixed before then won't be fixed for another week. |
Additional changes to cover yum as well, thanks to @npmdl Co-authored-by: npmdnl <80255813+npmdnl@users.noreply.github.com>
Removed Jessie reference Co-authored-by: npmdnl <80255813+npmdnl@users.noreply.github.com>
npmdnl
approved these changes
Apr 5, 2024
|
Hello @lpmhouben in order to merge this push request you need to solve conflicting files and commit changes. TY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the dnsdist-19 repo was the easy part; fixing the molecule tests for Debian 11 and 12 was a lot more work.