Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth, rec: update option text and docs to clarify logging is to stderr, not stdout #12989

Merged
merged 1 commit into from Mar 25, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Jul 5, 2023

PRing now so I don't forget, but this is not done: done:

  • update docs
  • check what dnsdist does

@Habbie Habbie added this to the common-soon milestone Jul 5, 2023
@Habbie
Copy link
Member Author

Habbie commented Mar 22, 2024

check what dnsdist does

dnsdist logs to stdout and says this correctly in the help text for --disable-syslog and --log-timestamps

@Habbie Habbie changed the title auth, rec: update option text to clarify logging is to stderr, not stdout auth, rec: update option text and docs to clarify logging is to stderr, not stdout Mar 22, 2024
@Habbie Habbie marked this pull request as ready for review March 22, 2024 16:27
@Habbie Habbie requested a review from omoerbeek March 22, 2024 16:28
@Habbie Habbie removed the dnsdist label Mar 22, 2024
pdns/dolog.hh Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8394648928

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 49 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.03%) to 59.209%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/pollmplexer.cc 1 82.39%
pdns/dnsdistdist/dnsdist-backend.cc 2 66.76%
pdns/packethandler.cc 3 72.51%
pdns/dnsdistdist/dnsdist-carbon.cc 3 63.9%
pdns/tsigverifier.cc 3 77.22%
pdns/iputils.hh 4 74.8%
pdns/recursordist/test-syncres_cc1.cc 7 89.61%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.83%
modules/godbcbackend/sodbc.cc 17 70.8%
Totals Coverage Status
Change from base Build 8392275634: -0.03%
Covered Lines: 113625
Relevant Lines: 158756

💛 - Coveralls

@omoerbeek omoerbeek merged commit ecbe6c3 into PowerDNS:master Mar 25, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants