Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: force CI failure if there are binaries present in a Pull Request #13608

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

romeroalx
Copy link
Contributor

Short description

Force CI failure if there are binaries present in a Pull Request.

The original request comes from this pull request

This is an example of a failure in the CodeQL workflow when a binary file is added to a PR: here

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7183689724

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.001%) to 57.674%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/dnsdistdist/dnsdist-backend.cc 2 74.15%
pdns/misc.hh 3 82.52%
pdns/rcpgenerator.cc 3 89.68%
pdns/recursordist/test-syncres_cc2.cc 3 88.99%
pdns/tsigverifier.cc 3 77.22%
pdns/dnsdist.cc 4 71.42%
pdns/signingpipe.cc 5 85.48%
modules/godbcbackend/sodbc.cc 17 70.8%
Totals Coverage Status
Change from base Build 7183281949: -0.001%
Covered Lines: 107468
Relevant Lines: 155015

💛 - Coveralls

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

.github/workflows/codeql-analysis.yml Show resolved Hide resolved
@romeroalx romeroalx marked this pull request as ready for review December 14, 2023 15:07
@Habbie Habbie merged commit 9e2a195 into PowerDNS:master Dec 19, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants