remove unneeded jobs for rel/auth-4.9.x branch

[Habbie]

Short description

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[omoerbeek]

Shouldn't this into the rel/auth-4.9.x branch and not into master?

[Habbie]

Shouldn't this into the rel/auth-4.9.x branch and not into master?

of course. Fixed :)

[coveralls]

Pull Request Test Coverage Report for Build 8278189299

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1520 unchanged lines in 55 files lost coverage.
• Overall coverage increased (+4.8%) to 63.075%

---

Files with Coverage Reduction	New Missed Lines	%
pdns/cachecleaner.hh	1	75.63%
pdns/pollmplexer.cc	1	81.76%
pdns/epollmplexer.cc	2	76.51%
pdns/logger.cc	2	78.49%
pdns/ws-api.cc	2	84.91%
ext/yahttp/yahttp/utility.hpp	2	36.47%
pdns/burtle.hh	2	96.32%
pdns/channel.hh	2	51.75%
pdns/proxy-protocol.cc	2	73.63%
pdns/dnswriter.cc	3	73.03%

Totals
Change from base Build 8262431453:	4.8%
Covered Lines:	41651
Relevant Lines:	59286

---

💛 - Coveralls

[omoerbeek]

Don't you want to keep this one? Or is the workflow from master used? (I never know that, I wish there was an easy way to tell).

[Habbie]

I'm pretty sure the one from master is used.

[rgacogne]

I'm not sure that's true, as I remember backporting these files to get proper packages for existing branches. I tried to find a definitive answer in GitHub's documentation but while I think I'm right I cannot find a clear answer.

[Habbie]

I also looked in the docs today and found a 'main branch' note on some other events. No clarity about this one. I'll put it the file back.

[jsoref]

on: push is based on the current commit that's pushed

on: pull_request is based on the merge of the base and head branches

on: pull_request_target is based on the base branch

on: issue_comment, on: schedule and a couple of other odd ones are based on the default branch

[rgacogne]

So we need to keep our stable branches up-to-date as far as workflows are concerned, except for the last events, if I reading this right?

[Habbie]

right, so the yml that picks up the push tag event needs to be on the right branch, but then we quickly invoke the actual building workflows from master, so it's not to obad

[jsoref]

You definitely need to keep workflows current on any branches that you have, otherwise if there are security risks in them, you're at risk.

You can rely on:
on: workflow_dispatch and have that take an input, and have your other workflows do an if: ... to cause them not to do work on branches/tags if you're so inclined.

[Habbie]

I have redone this from scratch

[romeroalx]

I think we could also remove tests for rec and dnsdist from this workflow, lines 59, 60, 147-247, and 261-268.

[Habbie]

the matrix change makes that code dead code, and leaving the dead code in makes backporting patches easier, if we ever have to

[Habbie]

removing the code makes github actions output easier to read, though.. it's a bit of a coin flip. I'll remove it and we'll see if it ever gets in the way

[Habbie]

haha, I rebased on the github sysctl workaround and now I have a conflict (in build-and-test-all, though, but it does show the problem)