Clean up SSQLite3::~SSQLite3

[jsoref]

Short description

Clean up SSQLite3::~SSQLite3

• The loop will run once or twice
• There used to be some cleanup that was done in the failure case but it has been gone for a while
• Clarify logic
• Report error message from sqlite3

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[coveralls]

Pull Request Test Coverage Report for Build 8348480499

Details

• 2 of 8 (25.0%) changed or added relevant lines in 1 file are covered.
• 34 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+0.002%) to 59.255%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/ssqlite3.cc	2	8	25.0%

Files with Coverage Reduction	New Missed Lines	%
pdns/ssqlite3.cc	1	66.77%
modules/lmdbbackend/lmdbbackend.cc	2	73.5%
pdns/recursordist/test-syncres_cc2.cc	3	88.85%
pdns/axfr-retriever.cc	3	65.53%
pdns/opensslsigners.cc	3	61.13%
modules/godbcbackend/sodbc.cc	6	70.8%
pdns/recursordist/test-syncres_cc1.cc	7	89.73%
pdns/packethandler.cc	9	72.51%

Totals
Change from base Build 8343656154:	0.002%
Covered Lines:	113667
Relevant Lines:	158716

---

💛 - Coveralls