Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-4.9: Fix memory leaks in the bind file format parser #14199

Merged
merged 1 commit into from
May 17, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented May 17, 2024

Short description

backport of #14196

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Some tokens were not properly freed: ACL names and entries, unused
word or quoted string terms. This is limited to the parsing of the
bind file format, zones themselves are fine, so there is no security
impact.
Found by LeakSanitizer over our existing unit tests.

(cherry picked from commit 9a8bd90)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9129386662

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+1.5%) to 63.076%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.56%
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/signingpipe.cc 7 83.87%
pdns/bindparser.cc 58 58.46%
Totals Coverage Status
Change from base Build 9129311465: 1.5%
Covered Lines: 41680
Relevant Lines: 59333

💛 - Coveralls

@Habbie Habbie merged commit c8f4c2c into PowerDNS:rel/auth-4.9.x May 17, 2024
30 checks passed
@Habbie Habbie deleted the backport-14196-to-auth-4.9.x branch May 17, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants