Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlarmConfig apply all TaskTracker #743

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

guangdashao
Copy link

What is the purpose of the change

添加报警人员时,报警设置不生效 #742

Brief changelog

It is best to associate an existing issue

Verifying this change

Do I need to test?
Has testing been completed?
Test method?

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 3 checklist before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Follow the git commit specification
    • feat: xxx -> The feat type is used to identify production changes related to new backward-compatible abilities or functionality.
    • perf: xxx -> The perf type is used to identify production changes related to backward-compatible performance improvements.
    • fix: xxx -> The fix type is used to identify production changes related to backward-compatible bug fixes.
    • docs: xxx -> The docs type is used to identify documentation changes related to the project - whether intended externally for the end users (in case of a library) or internally for the developers.
    • test: xxx -> The test type is used to identify development changes related to tests - such as refactoring existing tests or adding new tests.
    • refactor: xxx -> The refactor type is used to identify development changes related to modifying the codebase, which neither adds a feature nor fixes a bug - such as removing redundant code, simplifying the code, renaming variables, etc.

@dudiao
Copy link
Member

dudiao commented Sep 20, 2023

@guangdashao 非常感谢你的贡献。我发现在tech.powerjob.worker.core.tracker.task.heavy.FrequentTaskTracker.AlertManager已经有相关的逻辑,能否将AlertManager分离出来,适配所有类型的TaskTracker呢?

还需要注意代码缩进,清除无用的日志等

@dudiao dudiao changed the title New branch AlarmConfig apply all TaskTracker Sep 20, 2023
@guangdashao
Copy link
Author

@guangdashao 非常感谢你的贡献。我发现在tech.powerjob.worker.core.tracker.task.heavy.FrequentTaskTracker.AlertManager已经有相关的逻辑,能否将AlertManager分离出来,适配所有类型的TaskTracker呢?

还需要注意代码缩进,清除无用的日志等

FrequentTaskTracker这个是在worker中限制的吗?如果是在worker中限制,我启动了两个work,两个work中都有同一个job,这种情况下,FrequentTaskTracker.AlertManager是统计每个job的,还是统计的所有job的?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants