Instructor Assessment Access Overrides

[elisacarrillo]

Modifications from #7992
and fixed the tracking issues from #9050

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[elisacarrillo]

I have reviewed and hereby sign the CLA

[elisacarrillo]

recheck

[nwalters512]

Here's another pass. A lot of these comments were originally left on #7992 but were never addressed.

[elisacarrillo]

@elisacarrillo CI is failing again. Given the delay between you pushing and me approving CI runs, I'd strongly recommend running some basic CI checks locally to tighten up your feedback loop:

make lint-js
make build

Im having some issues with merge conflicts regarding selectAuthzAssessment. Will continue working on this today just wanted to give a heads up

[nwalters512]

@elisacarrillo sounds good, let me know if you need help getting the conflicts resolved!

[elisacarrillo]

@elisacarrillo sounds good, let me know if you need help getting the conflicts resolved!

Hi, Thank you so much I am having issues with the selectAuthzAssessment feature code added in 0b3ca7a. Specifically import { features } from '../lib/features';
I am getting the error

error TS2834: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.
@prairielearn/prairielearn:build:
@prairielearn/prairielearn:build: 8 import { features } from '../lib/features';

I was able to fix the merge issue but am unsure how to fix this linting issue. I have tried to add the /index.ts extension but it creates other issues when running. Would appreciate any advice! The most recent code is pushed. Thanks in advance!

[nwalters512]

Try pattern matching against other code in this PR. For instance, take a look at the relative imports in apps/prairielearn/src/pages/instructorAssessmentAccessOverrides/instructorAssessmentAccessOverrides.js. Do they have extensions, and if so, what extensions do they use?

[nwalters512]

@mwest1066 I'm wondering if we should special-case authz_mode == 'Exam' here so that instructors can't shoot themselves in the foot when using PrairieTest? Specifically, I'm thinking that perhaps we should ignore anything in assessment_access_policies when authz_mode === 'Exam'.

Even then, I guess one could still shoot oneself in the foot with access overrides: if a student has a PT reservation, the current implementation short-circuits and doesn't do the usual "block in public mode with active PT reservation" stuff. This would be a horribly contrived situation, and in this situation the student could already access things from outside a CBTF if such an override were in place...

I'm not sure what the right thing to do here is, but we should have a think about how access overrides interact with PT and exam mode.

[mwest1066]

I agree that we don't want access overrides to be used for providing access to PT-controlled exams (of course PT already has overrides for that) and we want to help people avoid footguns here. Let's add this to our list of planning topics as a near-term item to think about more carefully?

[mwest1066]

Added a note in the planning issue.

[codecov]

Codecov Report

Attention: Patch coverage is 15.73604% with 498 lines in your changes are missing coverage. Please review.

Project coverage is 66.59%. Comparing base (bb6b032) to head (ee2d44c).
Report is 2 commits behind head on master.

Files	Patch %	Lines
...rrides/instructorAssessmentAccessOverrides.html.ts	8.80%	290 Missing ⚠️
...ssOverrides/instructorAssessmentAccessOverrides.ts	14.81%	207 Missing ⚠️
apps/prairielearn/src/server.js	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9103      +/-   ##
==========================================
- Coverage   67.01%   66.59%   -0.43%     
==========================================
  Files         458      460       +2     
  Lines       71353    71944     +591     
  Branches     5719     5719              
==========================================
+ Hits        47820    47913      +93     
- Misses      23104    23601     +497     
- Partials      429      430       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.