New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New engine: add support for sync and async generator tasks #13138
Draft
jlowin
wants to merge
33
commits into
main
Choose a base branch
from
generators
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+672
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jlowin
changed the title
Add support for sync and async generator tasks
Add support for sync and async generator tasks (new engine)
Apr 27, 2024
jlowin
changed the title
Add support for sync and async generator tasks (new engine)
New engine: add support for sync and async generator tasks
Apr 28, 2024
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #12889 and #12915 to add native support for generator tasks to the new engine, both sync and async. It can be considered a draft until those are finalized. In Prefect 2.x you can decorate generators as tasks, but they are not preserved as generators. Instead, when the task is called the generator is fully consumed and the resulting list is returned as the task's result. This PR preserves true generator semantics. A task-decorated generator is still a "true" generator when called, and must be iterated over to produce values incrementally. The same goes for async generators.
Generator tasks inherit all properties of regular tasks, including retries.
This PR also enhances dependency tracking to automatically mark generators as "parent" tasks of any tasks that consume the values they yield.
This PR does not add support for generator flows.
There are now four distinct execution functions (run_task, run_task_sync, run_task_generator, and run_task_generator_sync) with almost identical logic, apart from syntactical requirements (like awaits and yields). DRYing them out would have certainly created conflicts with other PRs, so I am saving that optimization for once these are more dialed in.