Symfony login page improvement #36139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
May 13, 2024
•
jolelievre
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | This PR handles a few improvements from this epic #36001 |
| Type? | improvement |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | CI green UI tests green |
| UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/9094734532 |
| Fixed issue or discussion? | Fixes #36138 Fixes #36140 Fixes #36143 Fixes #36155 |
| Related PRs | ~ |
| Sponsor company | ~ |
jolelievre
force-pushed
the
login-improvements
branch
from
43dbf04
to
2fb37be
Compare
matthieu-rolland
previously approved these changes
May 13, 2024
jolelievre
force-pushed
the
login-improvements
branch
from
2fb37be
to
2821d76
Compare
jolelievre
force-pushed
the
login-improvements
branch
2 times, most recently
from
4eb03cc
to
44a743a
Compare
jolelievre
force-pushed
the
login-improvements
branch
from
dd81767
to
9c8bdd2
Compare
M0rgan01
reviewed
May 15, 2024
src/PrestaShopBundle/EventListener/Admin/Context/LanguageContextListener.php
Outdated
Show resolved
Hide resolved
src/PrestaShopBundle/EventListener/Admin/Context/ShopContextListener.php
Outdated
Show resolved
Hide resolved
src/PrestaShopBundle/EventListener/Admin/Context/ShopContextListener.php
Show resolved
Hide resolved
jolelievre
force-pushed
the
login-improvements
branch
from
9c8bdd2
to
ffe1644
Compare
M0rgan01
approved these changes
May 16, 2024
boherm
approved these changes
May 16, 2024
ps-jarvis
added
the
Waiting for QA
jolelievre
added
Waiting for QA
|
@matks Shouldn't this be tested by QA, just to be sure? Or it was agreed? It should be specified somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.