Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise UI tests and nightly #36210

Merged
merged 4 commits into from
May 24, 2024
Merged

Stabilise UI tests and nightly #36210

merged 4 commits into from
May 24, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented May 21, 2024 •
edited

Questions Answers
Branch? develop
Description? Add log exports after environment setup, add waiting script in docker initialization to make sure assets are built before the web server is started, increase composer timeout
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI green UI tests without cache OK
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/9212020695
Fixed issue or discussion? ~
Related PRs ~
Sponsor company ~

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 21, 2024
@jolelievre jolelievre force-pushed the add-logs-export branch 3 times, most recently from c1d574e to c0d6e60 Compare May 23, 2024 00:05
@jolelievre jolelievre force-pushed the add-logs-export branch 4 times, most recently from 8810785 to d662c44 Compare May 23, 2024 16:23
@jolelievre jolelievre force-pushed the add-logs-export branch 2 times, most recently from dfa3328 to cf99a16 Compare May 23, 2024 16:35
@jolelievre jolelievre changed the title Add more log exports in environment setup Stabilise UI tests and nightly May 23, 2024
@jolelievre jolelievre marked this pull request as ready for review May 23, 2024 17:06
@jolelievre jolelievre requested a review from a team as a code owner May 23, 2024 17:06
Progi1984
Progi1984 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for Nightly & Sanity Github Actions

@Progi1984 Progi1984 added this to the 9.0.0 milestone May 24, 2024
@nicosomb nicosomb added the Waiting for QA Status: action required, waiting for test feedback label May 24, 2024
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label May 24, 2024
@jolelievre
Copy link
Contributor Author

This only impacts tests in CI, no need for functional QA

@jolelievre jolelievre merged commit 375cd90 into PrestaShop:develop May 24, 2024
38 checks passed
@jolelievre jolelievre deleted the add-logs-export branch May 24, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@boherm boherm boherm approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
PR Dashboard
Status: Merged
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jolelievre @Progi1984 @boherm @nicosomb @prestonBot