Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: CI #108

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[Fix]: CI #108

merged 2 commits into from
Apr 6, 2023

Conversation

Kelhel
Copy link
Contributor

@Kelhel Kelhel commented Apr 6, 2023 •
edited

❓ Types of changes

The workflow CI don't work anymore

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

image

pnpm/pnpm#6307 (comment)

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes

@Kelhel Kelhel added the WIP Status: Work In Progress label Apr 6, 2023
aAmorim27
aAmorim27 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@aAmorim27 aAmorim27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me 👍
Just don't forget to do the same for the ci.yml file

puik/.github/workflows/ci.yml

Lines 20 to 21 in b0d4d56

with:
version: latest

Also you can pass this PR along with it
#106

@Kelhel Kelhel merged commit 0822c46 into main Apr 6, 2023
2 checks passed
@ga-devfront ga-devfront deleted the fix/build-pnpm-version branch November 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aAmorim27 aAmorim27 aAmorim27 approved these changes

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop approved these changes

Assignees
No one assigned
Labels
WIP Status: Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kelhel @aAmorim27 @cnavarro-prestashop