New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheme: Improvements #2263
Merged
RunDevelopment
merged 6 commits into
PrismJS:master
from
RunDevelopment:scheme-improvements-3
Apr 7, 2020
Merged
Scheme: Improvements #2263
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f32ba3
Scheme: Improvements
RunDevelopment 41b9f27
Added known failure
RunDevelopment 228cb4c
Merge branch 'master' into scheme-improvements-3
RunDevelopment 4dcc670
Further improved scheme numbers
RunDevelopment 17bf14c
Further improvements to number
RunDevelopment 74316c6
Merge branch 'master' into scheme-improvements-3
RunDevelopment File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
(lambda (foo bar) (concat foo bar)) | ||
|
||
---------------------------------------------------- | ||
|
||
[ | ||
["punctuation", "("], | ||
["keyword", "lambda"], | ||
["punctuation", "("], | ||
["lambda-parameter", "foo"], | ||
" bar", | ||
["punctuation", ")"], | ||
["punctuation", "("], | ||
["function", "concat"], | ||
" foo bar", | ||
["punctuation", ")"], | ||
["punctuation", ")"] | ||
] | ||
|
||
---------------------------------------------------- | ||
|
||
Checks for lambda parameters. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
'turkey | ||
(define a 'foo) | ||
|
||
---------------------------------------------------- | ||
|
||
[ | ||
["symbol", "'turkey"], | ||
["punctuation", "("], ["keyword", "define"], " a ", ["symbol","'foo"], ["punctuation",")"] | ||
] | ||
|
||
---------------------------------------------------- | ||
|
||
Checks for symbols. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't.
It explains the pattern by showing its simpler components, yes, but how do you know that the pattern is actually what's written there? I actually manually "generated" the pattern by substituting the rules myself, so I can tell you it's a pain... especially if you change something...
I'd rather have the pattern generated from a BNF.
We could implement a BNF-like syntax with #2190 and a syntax like this:
But this has a whole range of problems associated with it one of them being that minification basically impossible.