Line Highlight: Fixed linkable line numbers not being initialized #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of -62 B (-1.9%).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linkable line numbers were added for Line Highlight in #2328, I forgot to change the initialization logic.
This has now been fixed using the new
isActiveForfunction. Instead of a simpledata-lineattribute check, this function will now decide which elements get initialized. (This also has the nice side effect of removing some duplicate code.)A duplicate id in
line-highlight/index.htmlhas also been fixed.This fixes #2730.