Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Odin #3280

Closed
wants to merge 17 commits into from
Closed

Added support for Odin #3280

wants to merge 17 commits into from

Conversation

edukisto
Copy link
Contributor

Resolves #3204.

  1. I think, the only pattern that can be inherited from clike is function.

  2. I see no point in highlighting the names of built-in procedures (abs, align_of, u128le, etc.), since they are ordinary shadowable identifiers.

  3. The manual explicitly defines brackets and parentheses as operators. I’ll move them to the punctuation section if you like.

  4. I’ve added the following features which present both in the compiler and @gingerBill’s post, but remain undocumented:

    • the asm keyword;
    • the 0d, 0h, and 0z number prefixes;
    • the j and k number suffixes.
  5. No nested multiline comments :( See tests/languages/odin/failed_multiline_comment_feature.test.

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +784 B (+100.0%).

file master pull size diff % diff
components/prism-odin.min.js 0 Bytes 784 B +784 B +100.0%

Generated by 🚫 dangerJS against 6e85ff4

@edukisto edukisto changed the title Add Odin Added support for Odin Dec 14, 2021
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That you for the PR @edukisto!

components/prism-odin.js Outdated Show resolved Hide resolved
components/prism-odin.js Show resolved Hide resolved
components/prism-odin.js Show resolved Hide resolved
components/prism-odin.js Outdated Show resolved Hide resolved
components/prism-odin.js Outdated Show resolved Hide resolved
components/prism-odin.js Outdated Show resolved Hide resolved
tests/languages/odin/comment_feature.test Outdated Show resolved Hide resolved
tests/languages/odin/comment_feature.test Show resolved Hide resolved
components/prism-odin.js Outdated Show resolved Hide resolved
components/prism-odin.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

Please resolve the merge conflicts, and then we can merge this. Do the following steps:

  • Merge the master branch of this repo into this branch.
  • Run npm ci && npm run build. This will resolve the conflicts.
  • Commit all changes.

This should work. Don't be surprised by any minified files changing. We recently switched to a different minifier.

@RunDevelopment
Copy link
Member

I just merged #3424, so I'll close this now.

Thank you for contributing @edukisto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odin Programming Language
2 participants