Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Whitespace Plugin: add configuration via attributes #3467

Merged
merged 6 commits into from Jun 10, 2022
Merged

Normalize Whitespace Plugin: add configuration via attributes #3467

merged 6 commits into from Jun 10, 2022

Commits on Jun 9, 2022

  1. add settings configuration via attributes

    @plasticrake
    plasticrake committed Jun 9, 2022
    Copy the full SHA
    06d8db2 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. be more strict parsing data- attributes 

    // value, settingType
assert(t('', 'boolean') === true);
assert(t('true', 'boolean') === true);
assert(t('false', 'boolean') === false);
assert(t('invalid', 'boolean') === undefined);

assert(t('', 'number') === undefined);
assert(t('0', 'number') === 0);
assert(t('123', 'number') === 123);
assert(t('invalid', 'number') === undefined);
assert(t('123invalid456', 'number') === undefined);
    @plasticrake
    plasticrake committed Jun 10, 2022
    Copy the full SHA
    a0179c3 View commit details
    Browse the repository at this point in the history

  2. Use Number() instead of +

    @plasticrake
    plasticrake committed Jun 10, 2022
    Copy the full SHA
    fc65b1b View commit details
    Browse the repository at this point in the history

  3. Use JSON.parse 

    Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
    @plasticrake @RunDevelopment
    plasticrake and RunDevelopment committed Jun 10, 2022
    Copy the full SHA
    428363a View commit details
    Browse the repository at this point in the history

  4. Add semicolon

    @plasticrake
    plasticrake committed Jun 10, 2022
    Copy the full SHA
    fcb5952 View commit details
    Browse the repository at this point in the history

  5. Add built plugin file

    @plasticrake
    plasticrake committed Jun 10, 2022
    Copy the full SHA
    1d5d896 View commit details
    Browse the repository at this point in the history