New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements #1201
Merged
thescientist13
merged 12 commits into
release/0.30.0
from
feature/lit3-upgrade-and-ssr-fixes-and-enhancements
Mar 10, 2024
Merged
feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements #1201
thescientist13
merged 12 commits into
release/0.30.0
from
feature/lit3-upgrade-and-ssr-fixes-and-enhancements
Mar 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
Something isn't working
Plugins
Greenwood Plugins
CLI
feature
New feature or request
labels
Feb 1, 2024
thescientist13
changed the title
Feature/lit3 upgrade and ssr fixes and enhancements
Feature/issue 1197 lit3 upgrade and ssr fixes and enhancements
Feb 1, 2024
thescientist13
changed the title
Feature/issue 1197 lit3 upgrade and ssr fixes and enhancements
Feature/issue 1197 Lit v2 upgrade and SSR fixes and enhancements
Feb 1, 2024
thescientist13
changed the title
Feature/issue 1197 Lit v2 upgrade and SSR fixes and enhancements
Feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements
Feb 1, 2024
This was referenced Feb 11, 2024
thescientist13
changed the title
Feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements
enhancement/issue 1197 Lit v3 upgrade and SSR fixes and enhancements
Feb 27, 2024
thescientist13
changed the title
enhancement/issue 1197 Lit v3 upgrade and SSR fixes and enhancements
feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements
Feb 27, 2024
thescientist13
force-pushed
the
feature/lit3-upgrade-and-ssr-fixes-and-enhancements
branch
from
February 27, 2024 23:25
1629fb6
to
200a40f
Compare
thescientist13
force-pushed
the
feature/lit3-upgrade-and-ssr-fixes-and-enhancements
branch
from
March 10, 2024 01:40
02dff52
to
236e43f
Compare
thescientist13
deleted the
feature/lit3-upgrade-and-ssr-fixes-and-enhancements
branch
March 10, 2024 02:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
bug
Something isn't working
CLI
documentation
Greenwood specific docs
feature
New feature or request
needs upstream
Plugins
Greenwood Plugins
question
Further information is requested
SSR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1197
Depends on the following PRs being merged first
Summary of Changes
exportConditions
for SSR pages and API routes to now includenode
(like used in Lit's SSR implementation)getBody
API)0.12.0
TODO
globalThis
for state?)聽#880 and custom response and constructor props for SSR pages聽#1177export const hydration = true
export const function loader() => { /* ... */ }
customElements.define
issue - feature/discussion 1117 Isolation Mode (v1)聽#1206greenwood serve
only)? - https://lit.dev/docs/ssr/server-usage/#running-ssr-in-a-vm-module-or-the-global-scopeexport
to bring Workers back in on an opt-in basis?tokTypes
ofacorn-jsx
will be differentTokenType
classes ifacorn
itself is loaded via ESM聽acornjs/acorn-jsx#133require
of _package.json_ complicates bundling聽estools/escodegen#455greenwoodJsonLoader
getBody
limitation for SSR pagespreferBuiltins
for Lit in our Rollup config anymore?postinstall
- https://github.com/ProjectEvergreen/wcc/releases/tag/0.12.0false
true
confirm import map snapshot changes- confirmed that this got moved to SSR client - [ssr-client] Move experimental hydrate modules聽lit/lit#3720window
Thoughts / Questions
exportConditions
are still needed after upgrade Rollup and all plugins to3.x
聽#1087node
- [node-resolve] Support conditional exports defined in package.json聽rollup/plugins#362 (comment)type="module-shim"
馃shadowrootmode
thing?)