Fix Pass Extension click detection on iframe #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix animation fill See merge request web/clients!8805 Changelog:
This reverts commit aaa4f69.
[DRVWEB-3686] Revert "Migrate to react 18" See merge request web/clients!8778 Changelog:
Improve handling of 429 in uploads See merge request web/clients!8669 Changelog:
- Handle long texts in header upgrade buttons - remove space - Truncate text to prevent overlapping UXE-821
Better overflow handling for calendar header See merge request web/clients!8617 Changelog:
[DRVWEB-3386][DRVWEB-3388] Improve metadata for error reporting See merge request web/clients!8621 Changelog:
CALWEB-4838
…main' Deprecate CancelSingleOccurrenceWeb FF See merge request web/clients!8772 Changelog:
- In the web-app : client status is coupled to react state - throttling allows the caching saga to pick-up the latest status
[IDTEAM-2677]
[IDTEAM-2677] Max concurrent requests & inactive shares detection See merge request web/clients!8811 Changelog:
Fix Typescript error after emoji-mart update See merge request web/clients!8785 Changelog:
…'main' Fix button alignment in labels and folders section See merge request web/clients!8818 Changelog:
Inputs were missing a bit of context ("input number", but "input number what?").
- linked inputs between them using `aria-describedby`
- fixed some `id` which were not unique
UXE-668
Improve vocalization of notification form See merge request web/clients!8821 Changelog:
Dispatch thunks on idle period See merge request web/clients!8822 Changelog:
[IDTEAM] Regenerate pass api types See merge request web/clients!8917 Changelog:
MAILWEB-4854
Show the action to register mailto protocol in Chromium browser See merge request web/clients!8631 Changelog:
Changelog for calendar 5.0.21 See merge request web/clients!8892 Changelog:
Co-authored-by: Nicolas Hoffmann <dante3333@gmail.com>
Co-authored-by: Nicolas Hoffmann <dante3333@gmail.com>
Security Center See merge request web/clients!8551 Changelog:
If you disable animations (in settings or on the OS), reload spinner is not moving anymore when you refresh a folder. - Added an exception class, applied it to this case. It's an exception, where the animation must be kept, ie - it brings sense to the action - it's triggered by the user - it's super small and played less than 3s Doc: https://www.w3.org/WAI/GL/wiki/Animation_caused_by_user_interaction MAILWEB-4969
Fix reload spinner when animations are disabled See merge request web/clients!8919 Changelog:
Add mail changelog for 5.0.36 See merge request web/clients!8921
Fix public key fetching for passwordless org key See merge request web/clients!8920 Changelog:
[IDTEAM-2765]
- AutosaveService::reconciliation should only happen after detection runs - removed from GC call as this could lead to extraneous calls. - Check form is not submitting when reconciliating to avoid stashing form data on SPA pages or deferred page changes - Improve autosave documentation [IDTEAM-2765]
[IDTEAM-2765]
[IDTEAM-2765] Autosave regressions See merge request web/clients!8913 Changelog:
thomaslenaour
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an HTML element has the CSS property
pointer-events: none;and contains anemailinput field (ex: a form in a modal), the Proton Pass extension correctly detects this field but does not detect clicks on the options (iframe) during automatic email autofill. It seems this is due to the fact that the underlying element does not capture clicks.Reproduction Example (if necessary): https://github.com/thomaslenaour/proton-pass-extension-pointer-events-bug
Potential Solution
Add a CSS property
pointer-events: all !important;when the iframe is visible.