Parameter binding for API requests

Prowlarr · Apr 28, 2024 · 3e0af06 · 3e0af06
1 parent 858f85c
commit 3e0af06
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/src/Prowlarr.Api.V1/Commands/CommandController.cs b/src/Prowlarr.Api.V1/Commands/CommandController.cs
@@ -50,7 +50,7 @@ public override CommandResource GetResourceById(int id)
         [RestPostById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<CommandResource> StartCommand(CommandResource commandResource)
+        public ActionResult<CommandResource> StartCommand([FromBody] CommandResource commandResource)
         {
             var commandType =
                 _knownTypes.GetImplementations(typeof(Command))

diff --git a/src/Prowlarr.Api.V1/Config/ConfigController.cs b/src/Prowlarr.Api.V1/Config/ConfigController.cs
@@ -35,7 +35,7 @@ public TResource GetConfig()
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public virtual ActionResult<TResource> SaveConfig(TResource resource)
+        public virtual ActionResult<TResource> SaveConfig([FromBody] TResource resource)
         {
             var dictionary = resource.GetType()
                 .GetProperties(BindingFlags.Instance | BindingFlags.Public)

diff --git a/src/Prowlarr.Api.V1/Config/HostConfigController.cs b/src/Prowlarr.Api.V1/Config/HostConfigController.cs
@@ -125,7 +125,7 @@ public HostConfigResource GetHostConfig()
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<HostConfigResource> SaveHostConfig(HostConfigResource resource)
+        public ActionResult<HostConfigResource> SaveHostConfig([FromBody] HostConfigResource resource)
         {
             var dictionary = resource.GetType()
                                      .GetProperties(BindingFlags.Instance | BindingFlags.Public)

diff --git a/src/Prowlarr.Api.V1/Config/UiConfigController.cs b/src/Prowlarr.Api.V1/Config/UiConfigController.cs
@@ -35,7 +35,7 @@ public UiConfigController(IConfigFileProvider configFileProvider, IConfigService
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public override ActionResult<UiConfigResource> SaveConfig(UiConfigResource resource)
+        public override ActionResult<UiConfigResource> SaveConfig([FromBody] UiConfigResource resource)
         {
             var dictionary = resource.GetType()
                                      .GetProperties(BindingFlags.Instance | BindingFlags.Public)

diff --git a/src/Prowlarr.Api.V1/CustomFilters/CustomFilterController.cs b/src/Prowlarr.Api.V1/CustomFilters/CustomFilterController.cs
@@ -32,7 +32,7 @@ public List<CustomFilterResource> GetCustomFilters()
         [RestPostById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<CustomFilterResource> AddCustomFilter(CustomFilterResource resource)
+        public ActionResult<CustomFilterResource> AddCustomFilter([FromBody] CustomFilterResource resource)
         {
             var customFilter = _customFilterService.Add(resource.ToModel());
 
@@ -42,7 +42,7 @@ public ActionResult<CustomFilterResource> AddCustomFilter(CustomFilterResource r
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<CustomFilterResource> UpdateCustomFilter(CustomFilterResource resource)
+        public ActionResult<CustomFilterResource> UpdateCustomFilter([FromBody] CustomFilterResource resource)
         {
             _customFilterService.Update(resource.ToModel());
             return Accepted(resource.Id);

diff --git a/src/Prowlarr.Api.V1/Profiles/App/AppProfileController.cs b/src/Prowlarr.Api.V1/Profiles/App/AppProfileController.cs
@@ -23,7 +23,7 @@ public AppProfileController(IAppProfileService appProfileService)
         [RestPostById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<AppProfileResource> Create(AppProfileResource resource)
+        public ActionResult<AppProfileResource> Create([FromBody] AppProfileResource resource)
         {
             var model = resource.ToModel();
             model = _appProfileService.Add(model);
@@ -41,7 +41,7 @@ public object DeleteProfile(int id)
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<AppProfileResource> Update(AppProfileResource resource)
+        public ActionResult<AppProfileResource> Update([FromBody] AppProfileResource resource)
         {
             var model = resource.ToModel();
 

diff --git a/src/Prowlarr.Api.V1/ProviderControllerBase.cs b/src/Prowlarr.Api.V1/ProviderControllerBase.cs
@@ -232,7 +232,7 @@ public IActionResult TestAll()
         [HttpPost("action/{name}")]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public IActionResult RequestAction(string name, [FromBody] TProviderResource resource)
+        public IActionResult RequestAction([FromRoute] string name, [FromBody] TProviderResource resource)
         {
             var providerDefinition = GetDefinition(resource, false, false, false);
 

diff --git a/src/Prowlarr.Api.V1/Search/SearchController.cs b/src/Prowlarr.Api.V1/Search/SearchController.cs
@@ -55,7 +55,7 @@ public override ReleaseResource GetResourceById(int id)
         [HttpPost]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public async Task<ActionResult<ReleaseResource>> GrabRelease(ReleaseResource release)
+        public async Task<ActionResult<ReleaseResource>> GrabRelease([FromBody] ReleaseResource release)
         {
             ValidateResource(release);
 
@@ -89,7 +89,7 @@ public async Task<ActionResult<ReleaseResource>> GrabRelease(ReleaseResource rel
         [HttpPost("bulk")]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public async Task<ActionResult<ReleaseResource>> GrabReleases(List<ReleaseResource> releases)
+        public async Task<ActionResult<ReleaseResource>> GrabReleases([FromBody] List<ReleaseResource> releases)
         {
             releases.ForEach(release => ValidateResource(release));
 

diff --git a/src/Prowlarr.Api.V1/Tags/TagController.cs b/src/Prowlarr.Api.V1/Tags/TagController.cs
@@ -37,15 +37,15 @@ public List<TagResource> GetAll()
         [RestPostById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<TagResource> Create(TagResource resource)
+        public ActionResult<TagResource> Create([FromBody] TagResource resource)
         {
             return Created(_tagService.Add(resource.ToModel()).Id);
         }
 
         [RestPutById]
         [Consumes("application/json")]
         [Produces("application/json")]
-        public ActionResult<TagResource> Update(TagResource resource)
+        public ActionResult<TagResource> Update([FromBody] TagResource resource)
         {
             _tagService.Update(resource.ToModel());
             return Accepted(resource.Id);