Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consider replacing any usage of any with unknown #59 #62

Merged
merged 2 commits into from Apr 27, 2020
Merged

chore: consider replacing any usage of any with unknown #59 #62

merged 2 commits into from Apr 27, 2020

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Apr 17, 2020 •
edited

Fix #59

@regevbr regevbr self-assigned this Apr 17, 2020
@regevbr regevbr added the chore Make the code better label Apr 17, 2020
@regevbr regevbr requested a review from ynahmany April 17, 2020 18:49
@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited

Codecov Report

Merging #62 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   97.94%   97.94%   -0.01%     
==========================================
  Files          77       77              
  Lines        1413     1411       -2     
  Branches      166      167       +1     
==========================================
- Hits         1384     1382       -2     
  Misses         29       29
Flag Coverage Δ
#unittest 97.94% <100.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/db/interfaces/IConnectionSettings.ts 100.00% <ø> (ø)
...er/impl/resolvers/appveyor/appVeyorConfigParser.ts 100.00% <ø> (ø)
...er/impl/resolvers/circleci/circleCiConfigParser.ts 100.00% <ø> (ø)
...er/impl/resolvers/travisci/travisCiConfigParser.ts 100.00% <ø> (ø)
src/utils/logger/impl/loggerFactory.ts 100.00% <ø> (ø)
src/utils/logger/interfaces/ILogger.ts 100.00% <ø> (ø)
src/container/utils.ts 100.00% <100.00%> (ø)
src/db/impl/connectionOptionsProvider.ts 100.00% <100.00%> (ø)
src/db/impl/connectionProvider.ts 100.00% <100.00%> (ø)
src/db/index.ts 100.00% <100.00%> (ø)
... and 7 more

@regevbr
Copy link
Contributor Author

regevbr commented Apr 17, 2020

I had to patch the typings of Console...
I created a PR to fix them - unjs/consola#94

@regevbr regevbr added the pending code review pending code review label Apr 20, 2020
@regevbr
Copy link
Contributor Author

regevbr commented Apr 20, 2020

@ynahmany can you please CR?

ynahmany
ynahmany reviewed Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@ynahmany ynahmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
the tests have not been changed at all?

@regevbr
Copy link
Contributor Author

regevbr commented Apr 21, 2020 •
edited

@ynahmany nope, I just added type strictness, not changed the logic (in most of the changes at least)

ynahmany
ynahmany previously approved these changes Apr 27, 2020
View reviewed changes
@regevbr regevbr merged commit 24a515d into master Apr 27, 2020
@regevbr regevbr deleted the #59 branch April 27, 2020 12:22
@regevbr
Copy link
Contributor Author

regevbr commented Apr 27, 2020

@ynahmany thanks!

@regevbr regevbr removed the pending code review pending code review label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynahmany ynahmany ynahmany left review comments

Assignees

@regevbr regevbr

Labels
chore Make the code better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: consider replacing any usage of any with unknown
2 participants
@regevbr @ynahmany