Refuse to load archived RegionConfig in TopologyService.get (#1315)

This shouldn't get called for archived regions, but somehow it is, and it causes
big problems when the region in question is broken.
This will make it bail out rather than try to load an archived region, which
should limit the scope of the problem to whatever old entity is trying to
load it, rather than breaking the whole site.

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Updated database Terraform module to use the 'max_allocated_storage' param [#1312](https://github.com/PublicMapping/districtbuilder/pull/1312)
+- Made TopologyService check 'archived' status and refuse to load archived layers [#1315](https://github.com/PublicMapping/districtbuilder/pull/1315)
 
 ### Fixed
 

src/server/src/districts/services/topology.service.ts

@@ -76,6 +76,10 @@ export class TopologyService {
     if (!this._layers) {
       return;
     }
+    if (regionConfig.archived) {
+      this.logger.error(`Tried to load archived RegionConfig ${regionConfig.id}`);
+      return undefined;
+    }
     if (!(regionConfig.s3URI in this._layers)) {
       // If we encounter a new layer (i.e. one added after the service has started),
       // then store the results in the `_layers` object.