-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nest.js deps #637
Merged
Merged
Update Nest.js deps #637
Commits on Mar 18, 2021
-
via `nest update -f -t latest` (see nestjs/nest-cli#321 (comment)) TypeORM was also upgraded separately via `yarn upgrade --latest typeorm` since it seems it was installed as a sibling dependency (see 10fcff9#diff-d57c900a61f2746ea3823bed028e1d81004e1e077149e4b4935269ffb39383e8) which is also how the docs indicate it should be done (see https://docs.nestjs.com/techniques/database).
Configuration menu - View commit details
-
Copy full SHA for d4d1e32 - Browse repository at this point
Copy the full SHA d4d1e32View commit details -
Update Nest dependency types and fix import
Nest was failing to build since `HandlebarsAdapter` is no longer exported from the same module. The import was updated as per the current docs: https://nest-modules.github.io/mailer/docs/mailer `handlebars` was also added as a peer dependency since the docs said it should be installed if it is used (there was also a warning about this).
Configuration menu - View commit details
-
Copy full SHA for 553055d - Browse repository at this point
Copy the full SHA 553055dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ee0fa2 - Browse repository at this point
Copy the full SHA 4ee0fa2View commit details
Commits on Mar 19, 2021
-
Downgrade to avoid regression in minor version of @nestjsx/crud
When moving to 4.6.1+ an error is thrown at runtime when we try to list projects: server_1 | QueryFailedError: column Project.undefined does not exist This is related to the filtering of the project controller. In looking at the WHERE condition in the query to fetch the projects we can see where the query is being built incorrectly (a column `"Project"."undefined"` is referenced): server_1 | query failed: SELECT "Project"."id" AS "Project_id", "Project"."name" AS "Project_name", "Project"."number_of_districts" AS ... "regionConfig"."id"="Project"."region_config_id" INNER JOIN "user" "project_user" ON "project_user"."id"="Project"."user_id" WHERE ("Project"."undefined" = $1) ORDER BY "Project"."updated_dt" DESC -- PARAMETERS: ["07f9966f-facf-42ce-a4ee-48320007f1cc"] It seems like this should work fine since `user_id` is indeed a column on the project. An issue was created for this here: nestjsx/crud#684
Configuration menu - View commit details
-
Copy full SHA for 387d279 - Browse repository at this point
Copy the full SHA 387d279View commit details -
Finish upgrading all Nest.js deps
This makes it so that all deps which can be upgraded are upgraded. `class-transformer` had to be held back because upgrading it caused `@nestjsx/crud-typeorm` to throw an error since it seems to depend on an older version.
Configuration menu - View commit details
-
Copy full SHA for 2a22c69 - Browse repository at this point
Copy the full SHA 2a22c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b9b56 - Browse repository at this point
Copy the full SHA d6b9b56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72dd828 - Browse repository at this point
Copy the full SHA 72dd828View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.