Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nest.js deps #637

Merged
merged 7 commits into from
Mar 23, 2021
Merged

Update Nest.js deps #637

merged 7 commits into from
Mar 23, 2021

Commits on Mar 18, 2021

  1. Upgrade Nest dependencies

    via `nest update -f -t latest` (see
    nestjs/nest-cli#321 (comment))
    
    TypeORM was also upgraded separately via `yarn upgrade --latest typeorm`
    since it seems it was installed as a sibling dependency (see
    10fcff9#diff-d57c900a61f2746ea3823bed028e1d81004e1e077149e4b4935269ffb39383e8)
    which is also how the docs indicate it should be done (see
    https://docs.nestjs.com/techniques/database).
    pcaisse committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    d4d1e32 View commit details
    Browse the repository at this point in the history
  2. Update Nest dependency types and fix import

    Nest was failing to build since `HandlebarsAdapter` is no longer
    exported from the same module. The import was updated as per the current
    docs: https://nest-modules.github.io/mailer/docs/mailer
    
    `handlebars` was also added as a peer dependency since the docs said it
    should be installed if it is used (there was also a warning about this).
    pcaisse committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    553055d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ee0fa2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Downgrade to avoid regression in minor version of @nestjsx/crud

    When moving to 4.6.1+ an error is thrown at runtime when we try to list
    projects:
    
    server_1    | QueryFailedError: column Project.undefined does not exist
    
    This is related to the filtering of the project controller. In looking
    at the WHERE condition in the query to fetch the projects we can see
    where the query is being built incorrectly (a column
    `"Project"."undefined"` is referenced):
    
    server_1    | query failed: SELECT "Project"."id" AS "Project_id",
    "Project"."name" AS "Project_name", "Project"."number_of_districts" AS
    
    ...
    
    "regionConfig"."id"="Project"."region_config_id"  INNER JOIN "user"
    "project_user" ON "project_user"."id"="Project"."user_id" WHERE
    ("Project"."undefined" = $1) ORDER BY "Project"."updated_dt" DESC --
    PARAMETERS: ["07f9966f-facf-42ce-a4ee-48320007f1cc"]
    
    It seems like this should work fine since `user_id` is indeed a column
    on the project.
    
    An issue was created for this here:
    nestjsx/crud#684
    pcaisse committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    387d279 View commit details
    Browse the repository at this point in the history
  2. Finish upgrading all Nest.js deps

    This makes it so that all deps which can be upgraded are upgraded.
    
    `class-transformer` had to be held back because upgrading it caused
    `@nestjsx/crud-typeorm` to throw an error since it seems to depend on an
    older version.
    pcaisse committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    2a22c69 View commit details
    Browse the repository at this point in the history
  3. Pin to exact versions

    pcaisse committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    d6b9b56 View commit details
    Browse the repository at this point in the history
  4. Update changelog

    pcaisse committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    72dd828 View commit details
    Browse the repository at this point in the history