Add random.Random to B311 checks (#940)

The lowercase `random.random` already matches `random.Random` on Windows as well (due to being case-insensitive), but not on other platforms. Resolves: #926 Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
PyCQA · May 22, 2023 · 4182f6b · 4182f6b
1 parent 9e8813a
commit 4182f6b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/bandit/blacklists/calls.py b/bandit/blacklists/calls.py
@@ -189,7 +189,8 @@
 +------+---------------------+------------------------------------+-----------+
 | ID   |  Name               |  Calls                             |  Severity |
 +======+=====================+====================================+===========+
-| B311 | random              | - random.random                    | Low       |
+| B311 | random              | - random.Random                    | Low       |
+|      |                     | - random.random                    |           |
 |      |                     | - random.randrange                 |           |
 |      |                     | - random.randint                   |           |
 |      |                     | - random.choice                    |           |
@@ -513,6 +514,7 @@ def gen_blacklist():
             "B311",
             issue.Cwe.INSUFFICIENT_RANDOM_VALUES,
             [
+                "random.Random",
                 "random.random",
                 "random.randrange",
                 "random.randint",

diff --git a/examples/random_module.py b/examples/random_module.py
@@ -2,6 +2,7 @@
 import os
 import somelib
 
+bad = random.Random()
 bad = random.random()
 bad = random.randrange()
 bad = random.randint()

diff --git a/tests/functional/test_functional.py b/tests/functional/test_functional.py
@@ -396,8 +396,8 @@ def test_popen_wrappers(self):
     def test_random_module(self):
         """Test for the `random` module."""
         expect = {
-            "SEVERITY": {"UNDEFINED": 0, "LOW": 7, "MEDIUM": 0, "HIGH": 0},
-            "CONFIDENCE": {"UNDEFINED": 0, "LOW": 0, "MEDIUM": 0, "HIGH": 7},
+            "SEVERITY": {"UNDEFINED": 0, "LOW": 8, "MEDIUM": 0, "HIGH": 0},
+            "CONFIDENCE": {"UNDEFINED": 0, "LOW": 0, "MEDIUM": 0, "HIGH": 8},
         }
         self.check_example("random_module.py", expect)