Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors from pipeline in Python3.8 #494

Closed
tylerwince opened this issue May 14, 2019 · 5 comments · Fixed by #509
Closed

Fix errors from pipeline in Python3.8 #494

tylerwince opened this issue May 14, 2019 · 5 comments · Fixed by #509
Labels
bug Something isn't working
Milestone
Release 1.6.3

Comments

@tylerwince
Copy link
Contributor

Describe the bug
Pipeline currently does not pass on Python3.8

To Reproduce
Steps to reproduce the behavior:

  1. Checkout the builds running in Travis here

Expected behavior
Builds should pass on 3.8 as we move closer to beta and public release later this year.

Bandit version
all
@ericwb
Copy link
Member

ericwb commented May 14, 2019

Unfortunately, it's not a trivial fix due to changes in the AST, but work has started as part of #393.

@ericwb ericwb added this to the Near Future milestone May 14, 2019
@ericwb ericwb added the bug Something isn't working label May 14, 2019
@tylerwince
Copy link
Contributor Author

Bummer -- I may try to take a stab at working through this if you don't mind. Looks like the PR only has minimal changes so I could just apply them to a new branch

@fungi
Copy link

fungi commented Jun 9, 2019

Worth noting, cpython v3.8.0b1 was tagged last week so an increasing number of folks are going to start trying to use it and running into this.

@tylerwince
Copy link
Contributor Author

Tagging @ambv re:Conversation around the breaking change to ast

@tylerwince tylerwince mentioned this issue Jun 25, 2019
Merged
@tylerwince
Copy link
Contributor Author

#509 will fix this issue

@ericwb ericwb modified the milestones: Near Future, Release 1.6.3 Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.6.3
Development

Successfully merging a pull request may close this issue.

Fix 3.8 errors tylerwince/bandit
3 participants
@fungi @ericwb @tylerwince