Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.8 errors #509

Merged
merged 12 commits into from Jul 1, 2019
Merged

Fix 3.8 errors #509

merged 12 commits into from Jul 1, 2019

Conversation

tylerwince
Copy link
Contributor

Fixes #494

@tylerwince
Copy link
Contributor Author

@ericwb This fixes 3.8 so people can start using this on the beta again

@tylerwince
Copy link
Contributor Author

Just want to ping this to the top of your inbox @ericwb

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM

@ericwb ericwb merged commit 3d08246 into PyCQA:master Jul 1, 2019
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
@adideutsch
Copy link

Hi @ericwb @tylerwince ,

Not sure where this conversion exactly belongs. I've also opened an issue here.

Some background -
I am using bandit with Python 3.8.6 for a few months now. Running bandit today using the new version 1.6.3 (thanks!), I found out about new issues (B104, B608) that were not visible before (job completed successfully).
Initially, I suspected that the CLI tool on version 1.6.2 didn't parse some args properly until the update today (I noticed several new lines on today's run: "Using command line arg for ..." which were missing before). However, I am not really sure that's really the reason - other issues did appear in the past using the exact same test job.

Any idea why these issues were identified today all of a sudden? Being unable to pinpoint why this happened, I'm worried there might be other undetected issues.
If this has happened because of Python 3.8 support issues, how can users be aware that bandit is not fully supported by their current python version?
Implementation suggestion for 2 - modify 'python_requires)' on setup.py to have an upper limit as well, thus making installations fail on supported versions.

Thanks,
Adi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors from pipeline in Python3.8
3 participants