Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--exit-zero option #510

Merged
merged 6 commits into from Aug 20, 2019
Merged

--exit-zero option #510

merged 6 commits into from Aug 20, 2019

Conversation

maciejstromich
Copy link
Contributor

No description provided.

@maciejstromich maciejstromich mentioned this pull request Jul 2, 2019
Closed
tylerwince
tylerwince approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@tylerwince tylerwince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add -- I like this feature! Well done

frankyjquintero
frankyjquintero approved these changes Aug 19, 2019
View reviewed changes
Copy link

@frankyjquintero frankyjquintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI feature required

@frankyjquintero
Copy link

This feature is necessary for a CI environment where only the report is required for SonarQube or any other tool.

The --exit-zero parameter will prevent a pipeline from brokering and generating the report

ericwb
ericwb requested changes Aug 20, 2019
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however you'll also have to update https://github.com/PyCQA/bandit/blob/master/doc/source/man/bandit.rst with the new argument.

@maciejstromich
Copy link
Contributor Author

@ericwb I've added the missing docs to man page source.

@frankyjquintero
Copy link

@ericwb the requested changes @maciejstromich has finished them. Is this feature available in the next version as soon as possible? : D it would be great to be able to implement it as soon as possible.

@maciejstromich
Copy link
Contributor Author

@frankyjquintero for the time being you can just add

git+https://github.com/maciejstromich/bandit.git@exit_zero

to your requirements.txt (that's the branch from which this PR is being made)

ericwb
ericwb approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit eb67be7 into PyCQA:master Aug 20, 2019
florczakraf added a commit to florczakraf/bandit that referenced this pull request Aug 26, 2019
@florczakraf
Cleanup comments after PyCQA#510
7639ad9
@florczakraf florczakraf mentioned this pull request Aug 26, 2019
Merged
ericwb pushed a commit that referenced this pull request Aug 31, 2019
@florczakraf @ericwb
Cleanup comments after #510
922f401
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
@maciejstromich maciejstromich deleted the exit_zero branch March 31, 2021 13:52
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwb ericwb ericwb approved these changes

@tylerwince tylerwince tylerwince approved these changes

@frankyjquintero frankyjquintero frankyjquintero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maciejstromich @frankyjquintero @ericwb @tylerwince