Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to tox 4 #1020

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Switch to tox 4 #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99866cd
Update tox.ini to work with tox 4
mportesdev Apr 11, 2023
cade1d7
Use the `tox run` command
mportesdev Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
pip install -r test-requirements.txt
pip install tox
- name: Run tox
run: tox -e format
run: tox run -e format

pep8:
runs-on: ubuntu-latest
Expand All @@ -45,7 +45,7 @@ jobs:
pip install -r test-requirements.txt
pip install tox
- name: Run tox
run: tox -e pep8
run: tox run -e pep8

tests:
strategy:
Expand All @@ -70,4 +70,4 @@ jobs:
pip install -r test-requirements.txt
pip install tox
- name: Run tox
run: tox -e py${{ matrix.python-version[1] }}
run: tox run -e py${{ matrix.python-version[1] }}
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ You can test any changes with tox:

```shell script
pip install tox
tox -e pep8
tox -e py37
tox -e docs
tox -e cover
tox run -e pep8
tox run -e py37
tox run -e docs
tox run -e cover
```
If everything is done, proceed with [opening a new pull request](https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request)

Expand Down
14 changes: 9 additions & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
[tox]
minversion = 3.2.0
envlist = py37,pep8
skipsdist = True
requires =
tox<4

[testenv]
usedevelop = True
Expand All @@ -18,7 +15,13 @@ commands =
stestr run {posargs}
allowlist_externals =
find
passenv = http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY
passenv =
http_proxy
HTTP_PROXY
https_proxy
HTTPS_PROXY
no_proxy
NO_PROXY

[testenv:debug]
commands = oslo_debug_helper -t tests {posargs}
Expand All @@ -31,13 +34,14 @@ commands = flake8 {posargs} bandit
bandit-baseline -r bandit -ll -ii

[testenv:pep8]
skip_install = true
ignore_errors = true
deps = {[testenv]deps}
.
usedevelop = False
commands = flake8 {posargs} bandit
flake8 {posargs} tests
{[testenv:pylint]commands}
-{[testenv:pylint]commands}
bandit-baseline -r bandit -ll -ii

[testenv:venv]
Expand Down