Replace setattr #493
Merged
Replace setattr #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This also contains the changes from #492 and should be merged after that one is accepted. |
|
This PR can be merged after 1.6.1. I want 1.6.1 to contain just the regression bugs. |
|
@ericwb now that 1.6.2 is released with bug fixes, can we get a review on this? |
shadchin
reviewed
Aug 5, 2020
| @@ -211,7 +211,7 @@ def linerange(node): | |||
| for key in strip.keys(): | |||
| if hasattr(node, key): | |||
| strip[key] = getattr(node, key) | |||
| setattr(node, key, []) | |||
| node.key = [] | |||
There was a problem hiding this comment.
This is bug.
>>> key = "foo"
>>> setattr(node, key, [])
>>> node.foo
[]
>>> node.key
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'Node' object has no attribute 'key'| @@ -222,7 +222,7 @@ def linerange(node): | |||
|
|
|||
| for key in strip.keys(): | |||
| if strip[key] is not None: | |||
| setattr(node, key, strip[key]) | |||
| node.key = strip[key] | |||
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setattrdoesn't provide any value over setting the attribute directly via___ = ___. Also cleaned up a call toisinstancewhere we were checking the same item twice in a single conditional.