Add several ini options for .bandit file #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Bandit actually supports an ini file why not use it for (almost) all the available CLI options?!
ericwb
requested changes
Aug 18, 2019
| args.output_format = _log_option_source( | ||
| args.output_format, | ||
| ini_options.get('format'), | ||
| 'output format') |
There was a problem hiding this comment.
If the format parameter is allowed, we need to also support --msg-template in case someone chooses custom as the format.
| args.debug, | ||
| ini_options.get('debug'), | ||
| 'debug mode') | ||
|
|
| args.quiet, | ||
| ini_options.get('quiet'), | ||
| 'silent mode') | ||
|
|
There was a problem hiding this comment.
What about --ignore-nosec and --baseline ?
ericwb
approved these changes
Sep 23, 2019
ericwb
added a commit
that referenced
this pull request
Sep 24, 2019
Added the following missing ini options: * msg-template - necessary if output is a parameter * verbose * ignore-nosec * baseline Related to PR #508 Signed-off-by: Eric Brown <browne@vmware.com>
|
Hey @ericwb thanks for merging my changes and ofc sorry I can reply to you only now. |
|
@vuolter No worries. You're all good. Thanks for the contribution! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Bandit actually supports an ini file why not use it for (almost) all the available CLI options?!