Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking to name node of hashlib_new #516

Merged
merged 3 commits into from Sep 23, 2019
Merged

Add type checking to name node of hashlib_new #516

merged 3 commits into from Sep 23, 2019

Conversation

teeann
Copy link
Contributor

@teeann teeann commented Jul 16, 2019 •
edited by ericwb

Checks whether the name node is instead a str.

Fixes #504

@teeann teeann closed this Jul 16, 2019
@teeann teeann reopened this Jul 16, 2019
@ehooo ehooo mentioned this pull request Jul 26, 2019
Closed
@ehooo
Copy link
Contributor

ehooo commented Jul 26, 2019

@gaochua in order to link with the issue related you must add #504 on the comment, not in the title.

ericwb
ericwb requested changes Aug 18, 2019
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests and update the pull request with a detailed explanation of the change plus a reference to the bug you're fixing. Thanks!

@ericwb ericwb changed the title Fix #504 - Add type checking Add type checking to name node of hashlib_new Sep 23, 2019
ericwb
ericwb approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit 9e32438 into PyCQA:master Sep 23, 2019
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwb ericwb ericwb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6.3
Development

Successfully merging this pull request may close these issues.

hashlib_new_insecure_functions plugin fails to parse dynamic code
3 participants
@teeann @ehooo @ericwb