Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme file on Extending Bandit on list things #534

Merged
merged 3 commits into from Oct 4, 2019

Conversation

MrDolev
Copy link
Contributor

@MrDolev MrDolev commented Aug 31, 2019

Fix readme file on Extending Bandit on list things;
manager, fileobj, sev_level, conf_level, lines=-1
they were not listed on Markdown format

@ericwb
Copy link
Member

ericwb commented Sep 20, 2019

@aurel10 Please rebase and resolve conflicts, thanks!

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit changes, otherwise good to go.

README.rst Outdated
- `manager`: An instance of `bandit manager`
- `fileobj`: output file object
- `manager`: this is an instance of `bandit manager`
- `fileobj`: the output file object, which may be sys.stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there are two spaces after the ,

README.rst Outdated
manager, fileobj, sev_level, conf_level, lines=-1
- `manager`: An instance of `bandit manager`
- `fileobj`: output file object
- `manager`: this is an instance of `bandit manager`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `manager`: this is an instance of `bandit manager`
- `manager`: an instance of `bandit manager`

README.rst Outdated
- `sev_level` : Filtering severity level
- `conf_level`: Filtering confidence level
- `lines=-1`: Number of lines to report
- `lines=-1`: indicate the number of lines to report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `lines=-1`: indicate the number of lines to report
- `lines=-1`: number of lines to report

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit 9c5ec4a into PyCQA:master Oct 4, 2019
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants