Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore common directories by default #544

Merged
merged 2 commits into from Jan 20, 2020
Merged

Ignore common directories by default #544

merged 2 commits into from Jan 20, 2020

Conversation

ericwb
Copy link
Member

@ericwb ericwb commented Oct 7, 2019

This fix follows the example of flake8 in that it sets a default
list of common directories and filename patterns to exclude.
Fixes #543

Signed-off-by: Eric Brown browne@vmware.com

@bittner
Copy link
Contributor

bittner commented Oct 10, 2019

Makes sense.

This enhancement will also make .tox/ be ignored, which typically contains several virtualenvs with a load full of Python packages not needed to be verified. 👍

@ericwb ericwb changed the title Ignore hidden directories by default Ignore common directories by default Oct 13, 2019
ericwb and others added 2 commits October 12, 2019 22:58
This fix follows the example of flake8 in that it sets a default
list of common directories and filename patterns to exclude.

Fixes #543

Signed-off-by: Eric Brown <browne@vmware.com>
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea and looks good to me.

@lukehinds lukehinds merged commit c6b1302 into PyCQA:master Jan 20, 2020
@bittner
Copy link
Contributor

bittner commented Jan 20, 2020

Awesome! When is this change expected to hit a release?

@ericwb ericwb deleted the hidden branch January 20, 2020 18:50
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore virtualenv and __pycache__ directories
3 participants