Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing typo #582

Merged
merged 1 commit into from Mar 7, 2020
Merged

Conversation

Glyphack
Copy link
Contributor

@Glyphack Glyphack commented Mar 5, 2020

resolve

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Glyphack , I would revert the "How can I contribute" change back to linking to itself, as when you now click on the link with empty parenthesis () it gives a 404 page.

So change

[How Can I Contribute?]()

Back to:

[How Can I Contribute?](#how-can-i-contribute)

@Glyphack
Copy link
Contributor Author

Glyphack commented Mar 5, 2020

@lukehinds You're right I reverted it.

@Glyphack Glyphack requested a review from lukehinds March 5, 2020 18:30
@lukehinds
Copy link
Member

Thanks @Glyphack , could you squash the commits into one commit please. Details here:

https://github.com/PyCQA/bandit/blob/master/CONTRIBUTING.md#squash-commits

Resolves: PyCQA#576

Update table of contents.

Fix typo.

Revert removing how can i contribute link.
@lukehinds lukehinds merged commit 3e14530 into PyCQA:master Mar 7, 2020
@Glyphack Glyphack deleted the fix-contributing-typo branch March 8, 2020 11:11
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants