Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Support python3 venv creation #583

Merged
merged 2 commits into from Mar 7, 2020
Merged

Conversation

look4regev
Copy link
Contributor

In python3 there is no virtualenv. python2 is EOL. The venv directive should consider python3 first.

@lukehinds
Copy link
Member

Thanks for the PR!

I think you need to activate as well when using venv

source bandit-env/bin/activate

virtualenv seems to both create and activate at the same time.

@look4regev
Copy link
Contributor Author

look4regev commented Mar 7, 2020

Good comment, the source was also missing originally. Added.
(With virtualenv you do need the source as well. You might be talking about virtualenvwrapper as the one that also sources the venv for you (with mkvirtualenv)).

@lukehinds
Copy link
Member

thanks @look4regev , could you just squash your commits into one. Happy to merge then:

https://github.com/PyCQA/bandit/blob/master/CONTRIBUTING.md#squash-commits

@look4regev look4regev force-pushed the patch-1 branch 3 times, most recently from c58b7e8 to 60f8ee2 Compare March 7, 2020 19:12
In python3 there is no `virtualenv`. python2 is EOL. The venv directive should consider python3 first.
@look4regev
Copy link
Contributor Author

oh sure, sorry. Done. Thank you!

@lukehinds lukehinds merged commit a55e65d into PyCQA:master Mar 7, 2020
@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants